ilusha/blender
1
0
Fork 0
mirror of https://github.com/blender/blender synced 2026-09-29 04:37:17 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Python: improve exception message when renaming HTTP download fails

Browse source 
The HTTP downloader first downloads to a temporary file, only renaming
it to the final name once the download is completed. If this rename
fails, the error message now includes the old/new path of the rename
operation. Previously only the cause was shown (like "permission
denied") but not.

Pull Request: https://projects.blender.org/blender/blender/pulls/159042
This commit is contained in:
Sybren A. Stüvel 2026-05-25 12:42:10 +02:00
parent 7eb36afd15
commit 1a9bcab9e2
1 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
scripts/modules/_bpy_internal/http/downloader.py
View file

@ -180,7 +180,23 @@ class ConditionalDownloader:
return
# Move the downloaded file to the final filename.
os.replace(temp_path, local_path)
try:
os.replace(temp_path, local_path)
except OSError as ex:
# It's not really good form to both log and raise an exception, but in the
# log we can include the URL as well, providing some more information.
logger.error(
"after downloading %s %s, error renaming %s to %s: %s",
http_req_descr.http_method,
http_req_descr.url,
temp_path,
local_path,
ex)
# temp_path is in the same directory as local_path, so shorten the error
# message a bit by just using their filenames.
raise OSError(
"renaming downloaded file from {!s} to {!s} in {!s}: {!s}".format(
temp_path.name, local_path.name, local_path.parent, ex)) from None
self.metadata_provider.save(http_req_descr_with_headers, http_meta)