ilusha/blender
1
0
Fork 0
mirror of https://github.com/blender/blender synced 2026-09-29 04:37:17 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix (unreported) minor bug in RNA/Liboverride apply code.

Browse source 
The wrong RNA pointers were passed (passing the root ones instead of the
ones actually owning the rna-path-resolved property).

This was likely a harmless mistake, since it only affected RNA
collections of IDs, afaik we currently don't have many (if any) of these
in non-ID RNA structures. The children collections and objects in a
Collection data-block RNA structure e.g. were not affected.

But the potential consequence of that bug would have been missing
automatic detection of some needed liboverride resyncs.
This commit is contained in:
Bastien Montagne 2023-07-30 17:51:01 +02:00 • committed by Philipp Oeser
parent 4d3dda2222
commit 2ddfb23cb6
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
source/blender/makesrna/intern/rna_access_compare_override.c
View file

@ -1255,8 +1255,8 @@ void RNA_struct_override_apply(Main *bmain,
PointerRNA *ptr_item_dst, *ptr_item_src;
PointerRNA private_ptr_item_dst, private_ptr_item_src;
rna_porperty_override_collection_subitem_lookup(ptr_dst,
ptr_src,
rna_porperty_override_collection_subitem_lookup(&data_dst,
&data_src,
NULL,
prop_dst,
prop_src,