ilusha/blender
1
0
Fork 0
mirror of https://github.com/blender/blender synced 2026-09-29 04:37:17 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

PyAPI: Add useful exceptions to CollectionProperty.move()

Browse source 
The lack of exceptions for invalid indices makes bugs harder
to track down.

Also includes additional tests.

Ref !161833
This commit is contained in:
Oxicid 2026-08-02 03:28:36 +03:00 • committed by Campbell Barton
parent a873bd6561
commit 51efbf159a
5 changed files with 126 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

41
tests/python/bl_pyapi_prop.py
View file

@ -501,12 +501,14 @@ class TestPropCollectionAndPointer(unittest.TestCase):
id_type.test_pointer_ID = PointerProperty(type=bpy.types.ID)
id_type.test_pointer_ID_poll = PointerProperty(type=bpy.types.ID, poll=lambda s, v: v.id_type == 'OBJECT')
id_type.test_collection = CollectionProperty(type=TestPropertyGroup)
id_type.test_collection_move = CollectionProperty(type=TestPropertyGroup)
def tearDown(self):
del id_type.test_pointer
del id_type.test_pointer_ID
del id_type.test_pointer_ID_poll
del id_type.test_collection
del id_type.test_collection_move
bpy.utils.unregister_class(TestPropertyGroup)
@ -578,6 +580,45 @@ class TestPropCollectionAndPointer(unittest.TestCase):
self.assertNotEqual(id_inst.test_collection[1], test_item_3)
self.assertEqual(id_inst.test_collection[1].test_prop, 24)
def test_access_collection_move(self):
self.assertEqual(len(id_inst.test_collection_move), 0)
# Out of range in no-init empty collection.
with self.assertRaises(IndexError) as context:
id_inst.test_collection_move.move(0, 0)
self.assertEqual(str(context.exception), "bpy_prop_collection.move: index out of range")
# Out of range in init empty collection.
id_inst.test_collection_move.add()
id_inst.test_collection_move.clear()
with self.assertRaises(IndexError) as context:
id_inst.test_collection_move.move(0, 0)
self.assertEqual(str(context.exception), "bpy_prop_collection.move: index out of range")
# Fill.
for i in range(4):
id_inst.test_collection_move.add().test_prop = i
# Out of range.
with self.assertRaises(IndexError) as context:
id_inst.test_collection_move.move(0, 4)
self.assertEqual(str(context.exception), "bpy_prop_collection.move: index out of range")
# Negative index.
with self.assertRaises(IndexError) as context:
id_inst.test_collection_move.move(-1, 0)
self.assertEqual(str(context.exception), "bpy_prop_collection.move: index out of range")
# Regular move case.
id_inst.test_collection_move.move(0, 3)
self.assertEqual([i.test_prop for i in id_inst.test_collection_move], [1, 2, 3, 0])
# Single element move.
id_inst.test_collection_move.clear()
test_item = id_inst.test_collection_move.add()
id_inst.test_collection_move.move(0, 0)
self.assertEqual(id_inst.test_collection_move[0], test_item)
# TODO: Add expected failure cases (e.g. assigning propertygroup to a Pointer property, etc.).