ilusha/blender
1
0
Fork 0
mirror of https://github.com/blender/blender synced 2026-09-29 04:37:17 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup: Various non-functional pbvh_bmesh.cc changes

Browse source 
* Change #define constant value to static constexpr
* Adds const where possible
* Uses reference instead of pointer where possible
* Uses `float3` instead of raw float array where possible
* Uses std::optional to indicate value that may be null
* Reduces scope of variables where possible
* Uses `std::array` instead of raw arrays where possible
* Combines assignment and declaration where possible
* Lengthens some names from single letters

Pull Request: https://projects.blender.org/blender/blender/pulls/135486
This commit is contained in:
Sean Kim 2025-04-02 21:28:19 +02:00 • committed by Sean Kim
parent 3cb1749c31
commit 5546fe9848
4 changed files with 288 additions and 284 deletions
Download patch file Download diff file Expand all files Collapse all files

10
source/blender/blenkernel/BKE_paint_bvh.hh
View file

@ -369,15 +369,15 @@ bool node_raycast_grids(const SubdivCCG &subdiv_ccg,
bool node_raycast_bmesh(BMeshNode &node,
const float3 &ray_start,
const float3 &ray_normal,
IsectRayPrecalc *isect_precalc,
const IsectRayPrecalc *isect_precalc,
float *depth,
bool use_original,
BMVert **r_active_vertex,
float3 &r_face_normal);
bool raycast_node_detail_bmesh(BMeshNode &node,
bool raycast_node_detail_bmesh(const BMeshNode &node,
const float3 &ray_start,
IsectRayPrecalc *isect_precalc,
const IsectRayPrecalc *isect_precalc,
float *depth,
float *r_edge_length);
@ -466,8 +466,8 @@ bool bmesh_update_topology(BMesh &bm,
PBVHTopologyUpdateMode mode,
float min_edge_len,
float max_edge_len,
const float center[3],
const float view_normal[3],
const float3 &center,
const std::optional<float3> &view_normal,
float radius,
bool use_frontface,
bool use_projected);

558
source/blender/blenkernel/intern/pbvh_bmesh.cc
View file

File diff suppressed because it is too large Load diff

2
source/blender/editors/sculpt_paint/sculpt_detail.cc
View file

@ -148,7 +148,7 @@ static wmOperatorStatus sculpt_detail_flood_fill_exec(bContext *C, wmOperator *o
min_edge_len,
max_edge_len,
center,
nullptr,
std::nullopt,
size,
false,
false))

2
source/blender/makesdna/DNA_customdata_types.h
View file

@ -260,5 +260,3 @@ enum {
/* Limits */
#define MAX_MTFACE 8
#define DYNTOPO_NODE_NONE -1