ilusha/blender
1
0
Fork 0
mirror of https://github.com/blender/blender synced 2026-09-29 04:37:17 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix T84624: node group data-block has phantom user

Browse source 
This is because the node editor added a "real user" to the node group
that it displays. It was mainly added as a hack to solve issues with custom
tree types (T36024). Since we can store id references in custom properties
now, this "real user" is not really necessary anymore.

Given that we are close to a release, I'll only disable line for geometry nodes,
for which the bug has been reported.

Discussed this solution with Hans Goudey.
This commit is contained in:
Jacques Lucke 2021-02-15 19:29:09 +01:00
parent 7c864388fc
commit 9cccbbebaa
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
source/blender/editors/space_node/space_node.c
View file

@ -80,7 +80,12 @@ void ED_node_tree_start(SpaceNode *snode, bNodeTree *ntree, ID *id, ID *from)
BLI_addtail(&snode->treepath, path);
id_us_ensure_real(&ntree->id);
if (ntree->type != NTREE_GEOMETRY) {
/* This can probably be removed for all node tree types. It mainly exists because it was not
* possible to store id references in custom properties. Also see T36024. I don't want to
* remove it for all tree types in bcon3 though. */
id_us_ensure_real(&ntree->id);
}
}
/* update current tree */