ilusha/blender
1
0
Fork 0
mirror of https://github.com/blender/blender synced 2026-09-29 04:37:17 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix #148890: Spin tool floating-point error in extrude path

Browse source 
This was already fixed for the "duplicate" code-path,
resolve for the "extrude" code-path by reusing the rotation matrix.

Ref !156356
This commit is contained in:
Aditya Singh 2026-04-15 13:35:35 +10:00 • committed by Campbell Barton
parent af072493a2
commit b20e99a626
1 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
source/blender/bmesh/operators/bmo_dupe.cc
View file

@ -624,19 +624,14 @@ void bmo_spin_exec(BMesh *bm, BMOperator *op)
true);
BMO_op_exec(bm, &extop);
if ((use_merge && (a == steps - 1)) == false) {
/* For extrude mode, we need to rotate the extruded geometry.
* The extruded geometry is at the position of the previous step,
* so we rotate it by phi to get to the current step position. */
const float step_angle_prev = angle_total * (float(a) / float(steps));
const float step_angle_curr = angle_total * (float(a + 1) / float(steps));
const float step_angle_delta = step_angle_curr - step_angle_prev;
float rmat_delta[3][3];
axis_angle_normalized_to_mat3(rmat_delta, axis, step_angle_delta);
/* For extrude mode, rotate the extruded geometry to the current step position.
* Use `rmat` which is computed fresh each step from the origin angle to avoid
* floating-point error accumulation. */
BMO_op_callf(bm,
op->flag,
"rotate cent=%v matrix=%m3 space=%s verts=%S",
cent,
rmat_delta,
rmat,
op,
"space",
&extop,