Cleanup: Inappropriate includes in DNA_userdef_types.h

Summary:
- Replace `BLI_rect.h` with smaller and more appropriate
  `DNA_vec_types.h` for the `rctf` structs
- Replace `DNA_ID.h` with smaller and more appropriate `DNA_defs.h` for
  the DNA defines that are used
- Remove an unneeded forward declaration since we need the full
  `DNA_colorband_types.h` header anyhow

Pull Request: https://projects.blender.org/blender/blender/pulls/151508

release/datafiles/userdef/userdef_default.c

@@ -7,6 +7,7 @@
 /* For constants. */
 #include "BLI_math_constants.h"
 
+#include "DNA_ID.h"
 #include "DNA_anim_enums.h"
 #include "DNA_curve_enums.h"
 #include "DNA_space_enums.h"

source/blender/editors/interface/regions/interface_region_color_picker.cc

@@ -17,6 +17,7 @@
 #include "DNA_userdef_types.h"
 
 #include "BLI_listbase.h"
+#include "BLI_rect.h"
 #include "BLI_string_utf8.h"
 #include "BLI_utildefines.h"
 

source/blender/editors/render/render_view.cc

@@ -11,6 +11,7 @@
 #include <cstring>
 
 #include "BLI_listbase.h"
+#include "BLI_rect.h"
 
 #include "DNA_scene_types.h"
 #include "DNA_userdef_types.h"

source/blender/editors/uvedit/uvedit_unwrap_ops.cc

@@ -28,6 +28,7 @@
 #include "BLI_math_rotation.h"
 #include "BLI_math_vector.h"
 #include "BLI_memarena.h"
+#include "BLI_rect.h"
 #include "BLI_string_utf8.h"
 #include "BLI_time.h"
 #include "BLI_utildefines.h"

source/blender/makesdna/DNA_action_types.h

@@ -17,7 +17,6 @@
 #include "DNA_listBase.h"
 #include "DNA_session_uid_types.h"
 #include "DNA_userdef_types.h" /* ThemeWireColor */
-#include "DNA_vec_types.h"
 #include "DNA_view2d_types.h"
 
 #include "BLI_enum_flags.hh"

source/blender/makesdna/DNA_userdef_types.h

@@ -8,15 +8,13 @@
 
 #pragma once
 
-#include "BLI_rect.h"
-
-#include "DNA_ID.h"
 #include "DNA_colorband_types.h"
+#include "DNA_defs.h"
 #include "DNA_listBase.h"
 #include "DNA_theme_types.h" /* IWYU pragma: export */
 #include "DNA_userdef_enums.h"
+#include "DNA_vec_types.h"
 
-struct ColorBand;
 struct IDProperty;
 
 typedef struct bAddon {

source/blender/windowmanager/intern/wm_window_csd_layout.cc

@@ -10,6 +10,8 @@
 
 #include "GHOST_C-api.h"
 
+#include "BLI_rect.h"
+
 #include "WM_api.hh"
 #include "wm_window.hh"
 #include "wm_window_private.hh"