From ffe2abc38bc7d2812fbc716aeb2dd357b30fd3e5 Mon Sep 17 00:00:00 2001 From: Julian Eisel Date: Wed, 1 Jul 2026 10:03:51 +0200 Subject: [PATCH] Fix #160525: Potential crash when switching editors quickly Even though `filelist_readjob_stop()` was called to stop the read-job which also had code to cancel the job's timer, the timer callback would still be executed. The timer cancelling also handles pending timer events and timer handling correctly skipped cancelled timers. So it should all work. But I think when switching from the file browser to the asset browser, the effective job-type would change (the value returned by `filelist_jobtype_get()`), so we wouldn't find the correct job to cancel using the job type as part of the key. Just stick to the owner pointer as key for the job to cancel. Pull Request: https://projects.blender.org/blender/blender/pulls/160878 --- source/blender/editors/space_file/filelist/filelist_readjob.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/blender/editors/space_file/filelist/filelist_readjob.cc b/source/blender/editors/space_file/filelist/filelist_readjob.cc index 864ab54f18c..75e5701a60b 100644 --- a/source/blender/editors/space_file/filelist/filelist_readjob.cc +++ b/source/blender/editors/space_file/filelist/filelist_readjob.cc @@ -269,7 +269,7 @@ void filelist_readjob_blocking_run(FileList *filelist, int space_notifier, const void filelist_readjob_stop(FileList *filelist, wmWindowManager *wm) { - WM_jobs_kill_type(wm, filelist, filelist_jobtype_get(filelist)); + WM_jobs_kill_all_from_owner(wm, filelist); } int filelist_readjob_running(FileList *filelist, wmWindowManager *wm)