mirror of
https://github.com/blender/blender
synced 2026-10-25 03:07:01 +03:00
Clang on windows has always been generous with the amount of warnings
it emitted, no-one really had/took the time to take a closer look here
and we just suppressed [1] the warnings and moved on with our day.
However every-time a new clang version gets released more and more
warnings had to be suppressed, the tests for which flags are available
was reported to take 5+ minutes for some users, with more devs taking
clang for a spin, time to finally take that closer look!
Jonas dove in the docs and figured out that passing `-Wall` for clang-cl
doesn't do what you think it does and actually enables `-Weverything`[2]
which is the root cause for the abundance of warnings by clang on
windows.
This PR:
- Removes `-Wall` for clang on windows and replaces it with /W3 (which
will imply an _actual_ -Wall)
- Removes the large list of suppressions we had for clang on Windows
and synchronizes with the existing warning flags for Mac/Linux.
With this done there were about 200 warnings left in mostly windows
specific code (See PR for specifics) which this PR also fixes.
[1]
|
||
|---|---|---|
| .. | ||
| curve_fit_corners_detect.c | ||
| curve_fit_cubic.c | ||
| curve_fit_cubic_refit.c | ||
| curve_fit_inline.h | ||
| curve_fit_intern.h | ||
| generic_alloc_impl.h | ||
| generic_heap.c | ||
| generic_heap.h | ||