ilusha/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2026-09-29 10:35:30 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Issue12541 - Add UserWarning for unquoted realms

Browse source
This commit is contained in:
Senthil Kumaran 2012-05-15 23:59:42 +08:00
parent 34f3fcc269
commit 0ea91cb5c6
2 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Lib/test/test_urllib2.py
View file

@ -1227,11 +1227,12 @@ class HandlerTests(unittest.TestCase):
401, 'WWW-Authenticate: Basic realm=%s\r\n\r\n' % realm)
opener.add_handler(auth_handler)
opener.add_handler(http_handler)
self._test_basic_auth(opener, auth_handler, "Authorization",
realm, http_handler, password_manager,
"http://acme.example.com/protected",
"http://acme.example.com/protected",
)
with self.assertWarns(UserWarning):
self._test_basic_auth(opener, auth_handler, "Authorization",
realm, http_handler, password_manager,
"http://acme.example.com/protected",
"http://acme.example.com/protected",
)
def test_proxy_basic_auth(self):
opener = OpenerDirector()

4
Lib/urllib/request.py
View file

@ -95,6 +95,7 @@ import socket
import sys
import time
import collections
import warnings
from urllib.error import URLError, HTTPError, ContentTooShortError
from urllib.parse import (
@ -827,6 +828,9 @@ class AbstractBasicAuthHandler:
mo = AbstractBasicAuthHandler.rx.search(authreq)
if mo:
scheme, quote, realm = mo.groups()
if quote not in ["'", '"']:
warnings.warn("Basic Auth Realm was unquoted",
UserWarning, 2)
if scheme.lower() == 'basic':
response = self.retry_http_basic_auth(host, req, realm)
if response and response.code != 401: