ilusha/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2026-09-29 12:10:30 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

gh-91520: Rewrite imghdr inlining for clarity and completeness (#91521)

Browse source 
* Rewrite imghdr inlining for clarity and completeness

* Move MIMEImage class back closer to the top of the file since it's the
  important thing.
* Use a decorate to mark a given rule function and simplify the rule function
  names for clarity.
* Copy over all the imghdr test data files into the email package's test data
  directory.  This way when imghdr is actually removed, it won't affect the
  MIMEImage guessing tests.
* Rewrite and extend the MIMEImage tests to test for all supported
  auto-detected MIME image subtypes.
* Remove the now redundant PyBanner048.gif data file.

* See https://github.com/python/cpython/pull/91461#discussion_r850313336

Co-authored-by: Oleg Iarygin <dralife@yandex.ru>

Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
This commit is contained in:
Barry Warsaw 2022-04-14 17:48:59 -07:00 • committed by GitHub
parent ee475430d4
commit 1fcb39ea64
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
17 changed files with 152 additions and 117 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Doc/includes/email-mime.py
View file

@ -1,7 +1,7 @@
# Import smtplib for the actual sending function
# Import smtplib for the actual sending function.
import smtplib
# Here are the email package modules we'll need
# Here are the email package modules we'll need.
from email.message import EmailMessage
# Create the container email message.
@ -13,13 +13,13 @@ msg['From'] = me
msg['To'] = ', '.join(family)
msg.preamble = 'You will not see this in a MIME-aware mail reader.\n'
# Open the files in binary mode. Use imghdr to figure out the
# MIME subtype for each specific image.
# Open the files in binary mode. You can also omit the subtype
# if you want MIMEImage to guess it.
for file in pngfiles:
with open(file, 'rb') as fp:
img_data = fp.read()
msg.add_attachment(img_data, maintype='image',
subtype='jpeg')
subtype='png')
# Send the email via our own SMTP server.
with smtplib.SMTP('localhost') as s: