ilusha/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2026-09-29 12:10:30 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Issue #24735: Fix invalid memory access in combinations_with_replacement()

Browse source
This commit is contained in:
Raymond Hettinger 2015-07-28 02:05:44 -07:00
parent aaf6114b37
commit acd61b6e40
2 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Misc/NEWS
View file

@ -69,6 +69,9 @@ Library
- Issue #23441: rcompleter now prints a tab character instead of displaying
possible completions for an empty word. Initial patch by Martin Sekera.
- Issue #24735: Fix invalid memory access in
itertools.combinations_with_replacement().
- Issue #17527: Add PATCH to wsgiref.validator. Patch from Luca Sbardella.
- Issue #24683: Fixed crashes in _json functions called with arguments of

12
Modules/itertoolsmodule.c
View file

@ -2787,11 +2787,13 @@ cwr_next(cwrobject *co)
if (result == NULL)
goto empty;
co->result = result;
elem = PyTuple_GET_ITEM(pool, 0);
for (i=0; i<r ; i++) {
assert(indices[i] == 0);
Py_INCREF(elem);
PyTuple_SET_ITEM(result, i, elem);
if (n > 0) {
elem = PyTuple_GET_ITEM(pool, 0);
for (i=0; i<r ; i++) {
assert(indices[i] == 0);
Py_INCREF(elem);
PyTuple_SET_ITEM(result, i, elem);
}
}
} else {
/* Copy the previous result tuple or re-use it if available */