ilusha/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2026-09-28 07:18:17 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Issue #23207: Improved kwarg validation.

Browse source
This commit is contained in:
Vinay Sajip 2015-03-18 08:47:58 +00:00
parent ab6b9f8a5b
commit d55436ace3
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/logging/__init__.py
View file

@ -1734,8 +1734,8 @@ def basicConfig(**kwargs):
"specified together with 'handlers'")
if handlers is None:
filename = kwargs.pop("filename", None)
mode = kwargs.pop("filemode", 'a')
if filename:
mode = kwargs.pop("filemode", 'a')
h = FileHandler(filename, mode)
else:
stream = kwargs.pop("stream", None)

4
Lib/test/test_logging.py
View file

@ -3589,6 +3589,10 @@ class BasicConfigTest(unittest.TestCase):
handlers=handlers)
assertRaises(ValueError, logging.basicConfig, stream=stream,
handlers=handlers)
# Issue 23207: test for invalid kwargs
assertRaises(ValueError, logging.basicConfig, loglevel=logging.INFO)
# Should pop both filename and filemode even if filename is None
logging.basicConfig(filename=None, filemode='a')
def test_handlers(self):
handlers = [