ilusha/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2026-09-29 12:10:30 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

bpo-46678: Fix Invalid cross device link in Lib/test/support/import_helper.py (GH-31204)

Browse source 
In [Lib/test/support/import_helper.py](https://github.com/python/cpython/blob/master/Lib/test/support/import_helper.py), the function `make_legacy_pyc` makes a call to `os.rename` which can fail when the source and target live on different devices. This happens (for example) when `PYTHONPYCACHEPREFIX` is set to a directory anywhere on disk, while a ramdisk is mounted on `/tmp` (the latter of which is the default on various Linux distros). Replacing `os.rename` with `shutil.move` fixes this.

Automerge-Triggered-By: GH:brettcannon
This commit is contained in:
Jason Wilkes 2022-02-07 17:09:07 -08:00 • committed by GitHub
parent 7a0486eaa9
commit da576e0829
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/test/support/import_helper.py
View file

@ -3,6 +3,7 @@ import _imp
import importlib
import importlib.util
import os
import shutil
import sys
import unittest
import warnings
@ -59,7 +60,7 @@ def make_legacy_pyc(source):
pyc_file = importlib.util.cache_from_source(source)
up_one = os.path.dirname(os.path.abspath(source))
legacy_pyc = os.path.join(up_one, source + 'c')
os.rename(pyc_file, legacy_pyc)
shutil.move(pyc_file, legacy_pyc)
return legacy_pyc

3
Misc/NEWS.d/next/Tests/2022-02-07-12-40-45.bpo-46678.zfOrgL.rst Normal file
View file

@ -0,0 +1,3 @@
The function ``make_legacy_pyc`` in ``Lib/test/support/import_helper.py`` no
longer fails when ``PYTHONPYCACHEPREFIX`` is set to a directory on a
different device from where tempfiles are stored.