mirror of
https://github.com/python/cpython
synced 2026-11-16 20:24:40 +03:00
gh-155648: In IDLE tests, call unittest.main without exit arg (GH-156249)
* gh-155648: In IDLE tests, call unittest.main without exit arg
DD bug 73: In idlelib.idle_test, test_xyz.py files should end with
if __name__ == '__main__':
unittest.main(verbosity=2)
The default exit is True. This need not and should not be added.
5 files add the confusing equivalent exit=2 ("why the weird value?"),
4 files add exit=False. This is nonsensical when there is nothing more to run;
main will immediately exit anyway. When running a test file from an IDLE editor,
this argument has no visible effect. However, a Claude-based
bug finder claims that in other circumstances (such as a program running
the test in a shell), the good test may falsely fail. Even if this is
not true, it can only confuse a reader.
(The only place in idlelib for exit=False is in idlelib/abc.py files where the unittest
is followed by an htest. The default exit=True exits the process, skipping the htest.)
As part of editing the discussion of this in idle_test/htest.py, I clarified other things.
(cherry picked from commit c20318bf09)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
44 lines
1.5 KiB
Python
44 lines
1.5 KiB
Python
"Test delegator, coverage 100%."
|
|
|
|
from idlelib.delegator import Delegator
|
|
import unittest
|
|
|
|
|
|
class DelegatorTest(unittest.TestCase):
|
|
|
|
def test_mydel(self):
|
|
# Test a simple use scenario.
|
|
|
|
# Initialize an int delegator.
|
|
mydel = Delegator(int)
|
|
self.assertIs(mydel.delegate, int)
|
|
self.assertEqual(mydel._Delegator__cache, set())
|
|
# Trying to access a non-attribute of int fails.
|
|
self.assertRaises(AttributeError, mydel.__getattr__, 'xyz')
|
|
|
|
# Add real int attribute 'bit_length' by accessing it.
|
|
bl = mydel.bit_length
|
|
self.assertIs(bl, int.bit_length)
|
|
self.assertIs(mydel.__dict__['bit_length'], int.bit_length)
|
|
self.assertEqual(mydel._Delegator__cache, {'bit_length'})
|
|
|
|
# Add attribute 'numerator'.
|
|
mydel.numerator
|
|
self.assertEqual(mydel._Delegator__cache, {'bit_length', 'numerator'})
|
|
|
|
# Delete 'numerator'.
|
|
del mydel.numerator
|
|
self.assertNotIn('numerator', mydel.__dict__)
|
|
# The current implementation leaves it in the name cache.
|
|
# self.assertIn('numerator', mydel._Delegator__cache)
|
|
# However, this is not required and not part of the specification
|
|
|
|
# Change delegate to float, first resetting the attributes.
|
|
mydel.setdelegate(float) # calls resetcache
|
|
self.assertNotIn('bit_length', mydel.__dict__)
|
|
self.assertEqual(mydel._Delegator__cache, set())
|
|
self.assertIs(mydel.delegate, float)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main(verbosity=2)
|