mirror of
https://github.com/python/cpython
synced 2026-11-16 19:24:18 +03:00
gh-155648: In IDLE tests, call unittest.main without exit arg (GH-156249)
* gh-155648: In IDLE tests, call unittest.main without exit arg
DD bug 73: In idlelib.idle_test, test_xyz.py files should end with
if __name__ == '__main__':
unittest.main(verbosity=2)
The default exit is True. This need not and should not be added.
5 files add the confusing equivalent exit=2 ("why the weird value?"),
4 files add exit=False. This is nonsensical when there is nothing more to run;
main will immediately exit anyway. When running a test file from an IDLE editor,
this argument has no visible effect. However, a Claude-based
bug finder claims that in other circumstances (such as a program running
the test in a shell), the good test may falsely fail. Even if this is
not true, it can only confuse a reader.
(The only place in idlelib for exit=False is in idlelib/abc.py files where the unittest
is followed by an htest. The default exit=True exits the process, skipping the htest.)
As part of editing the discussion of this in idle_test/htest.py, I clarified other things.
(cherry picked from commit c20318bf09)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
80 lines
2.4 KiB
Python
80 lines
2.4 KiB
Python
"Test search, coverage 69%."
|
|
|
|
from idlelib import search
|
|
import unittest
|
|
from test.support import requires
|
|
requires('gui')
|
|
from tkinter import Tk, Text, BooleanVar
|
|
from idlelib import searchengine
|
|
|
|
# Does not currently test the event handler wrappers.
|
|
# A usage test should simulate clicks and check highlighting.
|
|
# Tests need to be coordinated with SearchDialogBase tests
|
|
# to avoid duplication.
|
|
|
|
|
|
class SearchDialogTest(unittest.TestCase):
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
cls.root = Tk()
|
|
|
|
@classmethod
|
|
def tearDownClass(cls):
|
|
cls.root.destroy()
|
|
del cls.root
|
|
|
|
def setUp(self):
|
|
self.engine = searchengine.SearchEngine(self.root)
|
|
self.dialog = search.SearchDialog(self.root, self.engine)
|
|
self.dialog.bell = lambda: None
|
|
self.text = Text(self.root)
|
|
self.text.insert('1.0', 'Hello World!')
|
|
|
|
def test_find_again(self):
|
|
# Search for various expressions
|
|
text = self.text
|
|
|
|
self.engine.setpat('')
|
|
self.assertFalse(self.dialog.find_again(text))
|
|
self.dialog.bell = lambda: None
|
|
|
|
self.engine.setpat('Hello')
|
|
self.assertTrue(self.dialog.find_again(text))
|
|
|
|
self.engine.setpat('Goodbye')
|
|
self.assertFalse(self.dialog.find_again(text))
|
|
|
|
self.engine.setpat('World!')
|
|
self.assertTrue(self.dialog.find_again(text))
|
|
|
|
self.engine.setpat('Hello World!')
|
|
self.assertTrue(self.dialog.find_again(text))
|
|
|
|
# Regular expression
|
|
self.engine.revar = BooleanVar(self.root, True)
|
|
self.engine.setpat('W[aeiouy]r')
|
|
self.assertTrue(self.dialog.find_again(text))
|
|
|
|
def test_find_selection(self):
|
|
# Select some text and make sure it's found
|
|
text = self.text
|
|
# Add additional line to find
|
|
self.text.insert('2.0', 'Hello World!')
|
|
|
|
text.tag_add('sel', '1.0', '1.4') # Select 'Hello'
|
|
self.assertTrue(self.dialog.find_selection(text))
|
|
|
|
text.tag_remove('sel', '1.0', 'end')
|
|
text.tag_add('sel', '1.6', '1.11') # Select 'World!'
|
|
self.assertTrue(self.dialog.find_selection(text))
|
|
|
|
text.tag_remove('sel', '1.0', 'end')
|
|
text.tag_add('sel', '1.0', '1.11') # Select 'Hello World!'
|
|
self.assertTrue(self.dialog.find_selection(text))
|
|
|
|
# Remove additional line
|
|
text.delete('2.0', 'end')
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main(verbosity=2)
|