mirror of
https://github.com/python/cpython
synced 2026-11-06 09:02:40 +03:00
a4ab2c1c69
gh-121617: Fix Py_CLEAR() in C++: replace NULL with _Py_NULL (#157067)
* Enhance Py_CLEAR() test in test_cext and test_cppext.
Check that Py_CLEAR(obj) sets obj to NULL.
* Add also tests on Py_SETREF() and Py_BEGIN_CRITICAL_SECTION().
(cherry picked from commit 36c7440c48)
107 lines
2.3 KiB
C
107 lines
2.3 KiB
C
// gh-116869: Basic C test extension to check that the Python C API
|
|
// does not emit C compiler warnings.
|
|
|
|
// Always enable assertions
|
|
#undef NDEBUG
|
|
|
|
#include "Python.h"
|
|
|
|
#ifndef MODULE_NAME
|
|
# error "MODULE_NAME macro must be defined"
|
|
#endif
|
|
|
|
#define _STR(NAME) #NAME
|
|
#define STR(NAME) _STR(NAME)
|
|
|
|
PyDoc_STRVAR(_testcext_add_doc,
|
|
"add(x, y)\n"
|
|
"\n"
|
|
"Return the sum of two integers: x + y.");
|
|
|
|
static PyObject *
|
|
_testcext_add(PyObject *Py_UNUSED(module), PyObject *args)
|
|
{
|
|
long i, j, res;
|
|
if (!PyArg_ParseTuple(args, "ll:foo", &i, &j)) {
|
|
return NULL;
|
|
}
|
|
res = i + j;
|
|
return PyLong_FromLong(res);
|
|
}
|
|
|
|
|
|
static PyMethodDef _testcext_methods[] = {
|
|
{"add", _testcext_add, METH_VARARGS, _testcext_add_doc},
|
|
{NULL, NULL, 0, NULL} // sentinel
|
|
};
|
|
|
|
|
|
static int
|
|
_testcext_exec(
|
|
#ifdef __STDC_VERSION__
|
|
PyObject *module
|
|
#else
|
|
PyObject *Py_UNUSED(module)
|
|
#endif
|
|
)
|
|
{
|
|
PyObject *obj;
|
|
|
|
#ifdef __STDC_VERSION__
|
|
if (PyModule_AddIntMacro(module, __STDC_VERSION__) < 0) {
|
|
return -1;
|
|
}
|
|
#endif
|
|
|
|
// test Py_BUILD_ASSERT() and Py_BUILD_ASSERT_EXPR()
|
|
Py_BUILD_ASSERT(sizeof(int) == sizeof(unsigned int));
|
|
assert(Py_BUILD_ASSERT_EXPR(sizeof(int) == sizeof(unsigned int)) == 0);
|
|
|
|
// Test Py_CLEAR(): use typeof()/__typeof__() if available, or memcpy()
|
|
obj = Py_None;
|
|
Py_CLEAR(obj);
|
|
assert(obj == NULL);
|
|
|
|
#ifndef Py_LIMITED_API
|
|
// Test Py_SETREF(): use typeof()/__typeof__() if available, or memcpy()
|
|
obj = Py_None;
|
|
Py_SETREF(obj, NULL);
|
|
assert(obj == NULL);
|
|
|
|
// Test that Py_BEGIN_CRITICAL_SECTION is available
|
|
Py_BEGIN_CRITICAL_SECTION(module);
|
|
Py_END_CRITICAL_SECTION();
|
|
#endif
|
|
|
|
return 0;
|
|
}
|
|
|
|
static PyModuleDef_Slot _testcext_slots[] = {
|
|
{Py_mod_exec, (void*)_testcext_exec},
|
|
{0, NULL}
|
|
};
|
|
|
|
|
|
PyDoc_STRVAR(_testcext_doc, "C test extension.");
|
|
|
|
static struct PyModuleDef _testcext_module = {
|
|
PyModuleDef_HEAD_INIT, // m_base
|
|
STR(MODULE_NAME), // m_name
|
|
_testcext_doc, // m_doc
|
|
0, // m_size
|
|
_testcext_methods, // m_methods
|
|
_testcext_slots, // m_slots
|
|
NULL, // m_traverse
|
|
NULL, // m_clear
|
|
NULL, // m_free
|
|
};
|
|
|
|
|
|
#define _FUNC_NAME(NAME) PyInit_ ## NAME
|
|
#define FUNC_NAME(NAME) _FUNC_NAME(NAME)
|
|
|
|
PyMODINIT_FUNC
|
|
FUNC_NAME(MODULE_NAME)(void)
|
|
{
|
|
return PyModuleDef_Init(&_testcext_module);
|
|
}
|