mirror of
https://github.com/python/cpython
synced 2026-11-14 17:07:19 +03:00
* gh-74112: Make Ctrl-C in the IDLE Shell interrupt blocking calls (GH-157662)
Send a real SIGINT to the main thread of the user process instead of
calling _thread.interrupt_main(), which only sets a flag checked
between bytecodes. The signal is sent while holding a new lock which
protects sending a message, so that the main thread is not interrupted
in the middle of a message. An interrupted wait for a response now
releases its lock, so that the socket thread does not deadlock.
(cherry picked from commit 9232c21a1c)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
62 lines
2.2 KiB
Python
62 lines
2.2 KiB
Python
"Test rpc, coverage 20%."
|
|
|
|
from idlelib import rpc
|
|
import socket
|
|
import struct
|
|
import threading
|
|
import unittest
|
|
from unittest import mock
|
|
|
|
|
|
class SocketIOTest(unittest.TestCase):
|
|
|
|
def test_reconnect_discards_partial_packet(self):
|
|
# gh-89544: RPCClient.accept() reinitializes the SocketIO after
|
|
# a restart; a partially received packet must not be kept.
|
|
old_sock, old_peer = socket.socketpair()
|
|
new_sock, new_peer = socket.socketpair()
|
|
with old_sock, old_peer, new_sock, new_peer:
|
|
sockio = rpc.SocketIO(old_sock)
|
|
old_peer.sendall(struct.pack('<i', 100) + b'x' * 10)
|
|
self.assertIsNone(sockio.pollpacket(1))
|
|
sockio.close()
|
|
rpc.SocketIO.__init__(sockio, new_sock)
|
|
new_peer.sendall(struct.pack('<i', 3) + b'abc')
|
|
self.assertEqual(sockio.pollpacket(1), b'abc')
|
|
|
|
def test_getresponse_interrupted(self):
|
|
# gh-74112: an interrupted wait must release the lock and forget
|
|
# the sequence number, so that a late response is discarded.
|
|
sockio = rpc.SocketIO(mock.Mock(), debugging=False)
|
|
sockio.sockthread = None # Not the current thread.
|
|
cvar = sockio.cvars[7] = threading.Condition()
|
|
with mock.patch.object(cvar, 'wait', side_effect=KeyboardInterrupt):
|
|
with self.assertRaises(KeyboardInterrupt):
|
|
sockio._getresponse(7, 0.05)
|
|
self.assertNotIn(7, sockio.cvars)
|
|
self.assertTrue(cvar.acquire(blocking=False))
|
|
cvar.release()
|
|
|
|
|
|
class CodePicklerTest(unittest.TestCase):
|
|
|
|
def test_pickle_unpickle(self):
|
|
def f(): return a + b + c
|
|
func, (cbytes,) = rpc.pickle_code(f.__code__)
|
|
self.assertIs(func, rpc.unpickle_code)
|
|
self.assertIn(b'test_rpc.py', cbytes)
|
|
code = rpc.unpickle_code(cbytes)
|
|
self.assertEqual(code.co_names, ('a', 'b', 'c'))
|
|
|
|
def test_code_pickler(self):
|
|
self.assertIn(type((lambda:None).__code__),
|
|
rpc.CodePickler.dispatch_table)
|
|
|
|
def test_dumps(self):
|
|
def f(): pass
|
|
# The main test here is that pickling code does not raise.
|
|
self.assertIn(b'test_rpc.py', rpc.dumps(f.__code__))
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main(verbosity=2)
|