ilusha/pbrt-v4
1
0
Fork 0
mirror of https://github.com/mmp/pbrt-v4 synced 2026-09-26 16:20:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 18

Correct return type of SampledGrid::MaxValue

Browse source 
I think this should be return type auto like all the other functions
in this class. I suspect the code compiles because at the moment all
uses of SampledGrid expect MaxValue to actually return type Float.
This commit is contained in:
Michael Priestman 2026-04-08 22:05:39 +01:00
parent 8c19f30455
commit bb5afcab9e
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/pbrt/util/containers.h
View file

@ -835,7 +835,7 @@ class SampledGrid {
}
template <typename F>
Float MaxValue(const Bounds3f &bounds, F convert) const {
auto MaxValue(const Bounds3f &bounds, F convert) const {
Point3f ps[2] = {Point3f(bounds.pMin.x * nx - .5f, bounds.pMin.y * ny - .5f,
bounds.pMin.z * nz - .5f),
Point3f(bounds.pMax.x * nx - .5f, bounds.pMax.y * ny - .5f,
@ -844,7 +844,7 @@ class SampledGrid {
Min(Point3i(Floor(ps[1])) + Vector3i(1, 1, 1),
Point3i(nx - 1, ny - 1, nz - 1))};
Float maxValue = Lookup(Point3i(pi[0]), convert);
auto maxValue = Lookup(Point3i(pi[0]), convert);
for (int z = pi[0].z; z <= pi[1].z; ++z)
for (int y = pi[0].y; y <= pi[1].y; ++y)
for (int x = pi[0].x; x <= pi[1].x; ++x)